Messages in this thread | | | Date | Tue, 26 Jan 2021 21:20:59 +0100 | From | Oleg Nesterov <> | Subject | Re: [PATCH v3] tracing: precise log info for kretprobe addr err |
| |
On 01/26, Masami Hiramatsu wrote: > > > > > > > IOW, the "offset != 0" check removed by this patch is obviously wrong, right? > > > > > No, not wrong. Even offset != 0, if the symbol exists in the kernel, > kprobe_on_func_entry() will check it.
Yes, but unless I am totally confused... if kprobe_on_func_entry() returns false, then trace_kprobe_create() should fail with BAD_RETPROBE even if offset == 0 ?
Oleg.
| |