Messages in this thread | | | Date | Tue, 26 Jan 2021 23:08:37 +0200 | From | Vladimir Oltean <> | Subject | Re: [PATCH 1/1] net: dsa: rtl8366rb: standardize init jam tables |
| |
Hi Lorenzo,
On Mon, Jan 25, 2021 at 05:56:31AM +0100, Lorenzo Carletti wrote: > In the rtl8366rb driver there are some jam tables which contain > undocumented values. > While trying to understand what these tables actually do, > I noticed a discrepancy in how one of those was treated.
And did you manage to find out what these tables actually do?
> Most of them were plain u16 arrays, while the ethernet one was > an u16 matrix. > By looking at the vendor's droplets of source code these tables came from, > I found out that they were all originally u16 matrixes. > > This commit standardizes the jam tables, turning them all into > u16 matrixes.
Why? What difference does it make?
> This change makes it easier to understand how the jam tables are used
No it doesn't?
> and also makes it possible for a single function to handle all of them, > removing some duplicated code.
On which RTL8366RB chip revisions did you test for regressions?
On another note, the patch doesn't apply cleanly to net-next/master.
| |