lkml.org 
[lkml]   [2021]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] tpm_tis: Add missing start/stop_tpm_chip calls
From
Date
On 26/01/2021 16:46, James Bottomley wrote:
> On Tue, 2021-01-26 at 16:46 +0100, Łukasz Majczak wrote:
>> Hi Jarkko, Guenter
>>
>> Yes, here are the logs when failure occurs -
>> https://gist.github.com/semihalf-majczak-lukasz/1575461f585f1e7fb1e9366b8eceaab9
>> Look for a phrase "TPM returned invalid status"
>
> We've had other reports of this:
>
> https://lore.kernel.org/linux-integrity/ghsgagsnag.fsf@gouders.net/
> https://lore.kernel.org/linux-integrity/374e918c-f167-9308-2bea-ae6bc6a3d2e3@elloe.vision/
>
> The problem is some TIS TPMs don't begin in the correct locality so we
> have to set it. When I proposed the check, I also proposed a fix for
> this problem:
>
> https://lore.kernel.org/linux-integrity/20201001180925.13808-5-James.Bottomley@HansenPartnership.com/
>
This patch solves the error messages on top of -rc5

> But it's part of a series that never went upstream. Part of the reason
> was Jarkko proposed the get/put patch to fix this instead, but that
> never went upstream either. We need to decide an approach and apply
> one or other fixes.
>
> James
>
>

\
 
 \ /
  Last update: 2021-01-27 03:59    [W:0.122 / U:3.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site