Messages in this thread | | | Subject | Re: [PATCH v3 4/5] amba: Make the remove callback return void | From | Suzuki K Poulose <> | Date | Tue, 26 Jan 2021 17:08:40 +0000 |
| |
Hi
On 1/26/21 4:58 PM, Uwe Kleine-König wrote: > All amba drivers return 0 in their remove callback. Together with the > driver core ignoring the return value anyhow, it doesn't make sense to > return a value here. > > Change the remove prototype to return void, which makes it explicit that > returning an error value doesn't work as expected. This simplifies changing > the core remove callback to return void, too. > > Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org> > Reviewed-by: Arnd Bergmann <arnd@arndb.de> > Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > Acked-by: Krzysztof Kozlowski <krzk@kernel.org> # for drivers/memory > Acked-by: Mark Brown <broonie@kernel.org> > Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > Acked-by: Linus Walleij <linus.walleij@linaro.org> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> drivers/hwtracing/coresight/coresight-etm4x-core.c | 4 +---
You are most likely to have a conflict for the above file, with what is in coresight/next. It should be easy to resolve.
Otherwise, the changes look good for the drivers/hwtracing/coresight/*
Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com>
| |