Messages in this thread | | | From | David Gow <> | Date | Tue, 26 Jan 2021 12:35:47 +0800 | Subject | Re: [PATCH 2/2] kcsan: Switch to KUNIT_CASE_PARAM for parameterized tests |
| |
On Thu, Jan 14, 2021 at 12:06 AM Marco Elver <elver@google.com> wrote: > > Since KUnit now support parameterized tests via KUNIT_CASE_PARAM, update > KCSAN's test to switch to it for parameterized tests. This simplifies > parameterized tests and gets rid of the "parameters in case name" > workaround (hack). > > At the same time, we can increase the maximum number of threads used, > because on systems with too few CPUs, KUnit allows us to now stop at the > maximum useful threads and not unnecessarily execute redundant test > cases with (the same) limited threads as had been the case before. > > Cc: David Gow <davidgow@google.com> > Signed-off-by: Marco Elver <elver@google.com> > ---
Thanks! This looks great from the KUnit point of view: I'm particularly excited to see a use of the parameterised test generator that's not just reading from an array.
I tested this as well, and it all seemed to work fine for me.
Reviewed-by: David Gow <davidgow@google.com>
Cheers, -- David
| |