Messages in this thread | | | Subject | Re: [PATCH 3/3] memory: mtk-smi: Switch MTK_SMI to tristate | From | Yong Wu <> | Date | Mon, 25 Jan 2021 18:11:00 +0800 |
| |
On Mon, 2021-01-25 at 09:44 +0100, Krzysztof Kozlowski wrote: > On Mon, Jan 25, 2021 at 02:49:44PM +0800, Yong Wu wrote: > > On Fri, 2021-01-22 at 22:35 +0100, Krzysztof Kozlowski wrote: > > > On Thu, Jan 21, 2021 at 02:24:29PM +0800, Yong Wu wrote: > > > > This patch switches MTK_SMI to tristate. Support it could be 'm'. > > > > > > > > Meanwhile, Fix a build issue while MTK_SMI is built as module. > > > > > > s/Fix/fix. > > > > > > What error is being fixed here? How can I reproduce it? Aren't you just > > > adjusting it to being buildable by module? > > > > Sorry, I didn't copy the fail log here. This is the build log: > > > > In file included from .../drivers/iommu/mtk_iommu.c:34:0: > > .../drivers/iommu/mtk_iommu.h:84:28: error: array type has incomplete > > element type 'struct mtk_smi_larb_iommu' > > struct mtk_smi_larb_iommu larb_imu[MTK_LARB_NR_MAX]; > > > > Our iommu driver will use this structure. but it was contained by > > "#ifdef CONFIG_MTK_SMI". thus I change it to "#if > > IS_ENABLED(CONFIG_MTK_SMI)" > > > > If reproducing it, we should change mtk-iommu to module_init[1]. and > > switch kconfig MTK_IOMMU to tristate, then change the CONFIG_MTK_IOMMU > > to m. we could get the fail log. > > > > In this case, Should I squash this change into this patch? I though this > > is a preparing patch and the fail is caused by MTK_SMI. thus I squash > > that into this patch. or change it as a independent patch and send when > > I change MTK_IOMMU to tristate? > > If I understand correctly, there is no error before this patch. In such > case just don't mention the error to fix, because it is simply part of > making things modular.
Yes. No error before this patch.
Appreciate for your help. I will remove this in the comment message in the next version.
> > Best regards, > Krzysztof >
| |