Messages in this thread | | | Date | Tue, 26 Jan 2021 14:31:55 +0800 | From | "liu xiang" <> | Subject | Re: [PATCH] pinctrl: sunxi: fix use-after-free in sunx i pmx free() |
| |
> On Thu, Jan 21, 2021 at 5:40 PM Maxime Ripard <maxime@cerno.tech> wrote: > On Tue, Jan 19, 2021 at 02:29:08PM +0800, Liu Xiang wrote: > > When CONFIG_REGULATOR is not set, sunxi_pmx_request() always return > > success. Even a group of pins call sunxi_pmx_request(), the refcount > > is only 1. This can cause a use-after-free warning in sunxi_pmx_free(). > > To solve this problem, go to err path if regulator_get() return NULL > > or error. > > > > Signed-off-by: Liu Xiang <liu.xiang@zlingsmart.com> > > Is there any drawback to depending on CONFIG_REGULATOR? > > Given that we need those regulators enabled anyway, I guess we could > just select or depends on it > > I agree. > > Liu can you make a patch to Kconfig to just select REGULATOR? > Possibly even the specific regulator driver this SoC is using > if it is very specific for this purpose. > > Yours, > Linus Walleij
I found that the regulator driver is related to the specific board, not the SoC. There is no board config for ARM64 SoC like ARM. Is a good idea to select the regulator driver in the pinctrl Konfig? Or just select CONFIG_REGULATOR_FIXED_VOLTAGE to avoid the use-after-free warning? | |