Messages in this thread | | | Date | Mon, 25 Jan 2021 10:25:10 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] mm/memory_hotplug: Rename all existing 'memhp' into 'mhp' |
| |
On Mon, Jan 25, 2021 at 02:21:02PM +0530, Anshuman Khandual wrote: > > > On 1/25/21 1:56 PM, Greg Kroah-Hartman wrote: > > On Mon, Jan 25, 2021 at 11:24:53AM +0530, Anshuman Khandual wrote: > >> This renames all 'memhp' instances to 'mhp' except for memhp_default_state > >> for being a kernel command line option. This is just a clean up and should > >> not cause a functional change. > > > > THat says _what_ you are doing, but I have no idea _why_ this is needed > > for anything... > > There is a series [1] which adds some new hotplug functions starting > with mhp_ (after deciding in its favor rather than memhp_). We should > have a common naming scheme either memhp_ based or mhp_ based but not > mixed. As it was proposed [2] to go with mhp_ based names instead, all > the existing memhp_ needed renaming. Hence the this patch.
And how was I supposed to know any of this by reading the changelog text? (hint, it needs to go in there...)
thanks,
greg k-h
| |