Messages in this thread | | | Subject | Re: [PATCH] Bluetooth: btusb: Add a Kconfig option to disable USB wakeup by default | From | Marcel Holtmann <> | Date | Mon, 25 Jan 2021 19:32:31 +0100 |
| |
Hi Max,
> For the original commit of 9e45524a011107a73bc2cdde8370c61e82e93a4d, > wakeup is always disabled for Realtek Bluetooth devices. > However, there's the capability for Realtek Bluetooth devices to > apply USB wakeup. Otherwise, there's the better power consumption > without USB wakeup during suspending. > In this commit, divide the original commit into two parts. > 1. Redefine the feature that Realtek devices should be enabled wakeup on > auto-suspend as BTUSB_WAKEUP_AUTOSUSPEND. > 2. Add a Kconfig option to switch disable_wakeup for Bluetooth > USB devices by default as CONFIG_BT_HCIBTUSB_DISABLEWAKEUP.
lets not make this so complicated. Lets just make this work. So define this based on the Realtek hardware that supports it and not just a generic option. If your hardware is broken or works different from revision to revision, then quirk it inside the driver.
Regards
Marcel
| |