lkml.org 
[lkml]   [2021]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] blk-mq: Use llist_head for blk_cpu_done
> +static void blk_mq_complete_send_ipi(struct request *rq)
> +{
> + struct llist_head *list;
> + unsigned int cpu;
> +
> + cpu = rq->mq_ctx->cpu;
> + list = &per_cpu(blk_cpu_done, cpu);
> + if (llist_add(&rq->ipi_list, list)) {
> + INIT_CSD(&rq->csd, __blk_mq_complete_request_remote, rq);
> + smp_call_function_single_async(cpu, &rq->csd);
> + }
> +}

Nit: it would be nice to initialize cpu and list in the declaration
lines.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

\
 
 \ /
  Last update: 2021-01-25 10:07    [W:0.176 / U:2.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site