Messages in this thread | | | Subject | Re: [PATCH] KVM: x86: allow KVM_REQ_GET_NESTED_STATE_PAGES outside guest mode for VMX | From | Paolo Bonzini <> | Date | Mon, 25 Jan 2021 22:59:48 +0100 |
| |
On 25/01/21 20:53, Sean Christopherson wrote: > Eh, I would argue that it is more common to do KVM_REQ_GET_NESTED_STATE_PAGES > with is_guest_mode() than it is with !is_guest_mode(), as the latter is valid if > and only if eVMCS is in use. But, I think we're only vying for internet points.:-) > >> however the idea was to remove the call to nested_get_evmcs_page from >> nested_get_vmcs12_pages, since that one is only needed after >> KVM_GET_NESTED_STATE and not during VMLAUNCH/VMRESUME. > > I'm confused, this patch explicitly adds a call to nested_get_evmcs_page() in > nested_get_vmcs12_pages().
What I really meant is that the patch was wrong. :/
I'll send my pull request to Linus without this one, and include it later this week.
Paolo
| |