Messages in this thread | | | From | Sami Tolvanen <> | Date | Mon, 25 Jan 2021 12:03:36 -0800 | Subject | Re: [PATCH] n_tty: fix redirected_tty_write checks after write_iter conversion |
| |
On Mon, Jan 25, 2021 at 11:45 AM Linus Torvalds <torvalds@linux-foundation.org> wrote: > > On Mon, Jan 25, 2021 at 11:27 AM Linus Torvalds > <torvalds@linux-foundation.org> wrote: > > > > Obvious ACK from me. > > Greg - if you have nothing else lined up in the tty tree, I can take > this fix directly if it's easier. > > And Sami - how did you actually notice? Some lint-like tool, or is > there something that actually broke from n_tty not handling a > redirected tty right?
Neither, I noticed this because the conflicting function declarations broke Clang's Control Flow Integrity checking.
Sami
| |