Messages in this thread | | | From | "Rafael J. Wysocki" <> | Date | Mon, 25 Jan 2021 17:08:55 +0100 | Subject | Re: [PATCH] ACPI / device_sysfs: Prefer "compatible" modalias |
| |
On Fri, Jan 22, 2021 at 2:06 PM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > On Fri, Jan 22, 2021 at 08:53:02PM +0800, Kai-Heng Feng wrote: > > Commit 8765c5ba1949 ("ACPI / scan: Rework modalias creation when > > "compatible" is present") may create two "MODALIAS=" in uevent file if > > conditions are met. > > > > This breaks systemd-udevd, which assumes each "key" in uevent file is > > unique. The internal implementation of systemd-udevd overwrites the > > first MODALIAS with the second one, so its kmod rule doesn't load driver > > for the first MODALIAS. > > > > So if both ACPI modalias and OF modalias are present, use the latter > > one to ensure there's only one MODALIAS. > > > > Reference: https://github.com/systemd/systemd/pull/18163 > > Cc: AceLan Kao <acelan.kao@canonical.com> > > Cc: "Rafael J. Wysocki" <rafael@kernel.org> > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Suggested-by: Mika Westerberg <mika.westerberg@linux.intel.com> > > Fixes: 8765c5ba1949 ("ACPI / scan: Rework modalias creation when "compatible" is present") > > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> > > --- > > drivers/acpi/device_sysfs.c | 20 ++++++-------------- > > 1 file changed, 6 insertions(+), 14 deletions(-) > > Thanks for fixing this up! > > Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Applied as 5.11-rc material with some minor edits in the subject and changelog and with the tags.
Thanks everyone!
| |