Messages in this thread | | | Date | Sun, 24 Jan 2021 11:31:43 +0000 | From | Christoph Hellwig <> | Subject | Re: [PATCH v10 01/12] mm/vmalloc: fix vmalloc_to_page for huge vmap mappings |
| |
On Sun, Jan 24, 2021 at 06:22:19PM +1000, Nicholas Piggin wrote: > vmalloc_to_page returns NULL for addresses mapped by larger pages[*]. > Whether or not a vmap is huge depends on the architecture details, > alignments, boot options, etc., which the caller can not be expected > to know. Therefore HUGE_VMAP is a regression for vmalloc_to_page. > > This change teaches vmalloc_to_page about larger pages, and returns > the struct page that corresponds to the offset within the large page. > This makes the API agnostic to mapping implementation details.
Maybe enable instead of fix would be better in the subject line?
Otherwise this looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
| |