Messages in this thread | | | Subject | Re: [PATCH 1/4] ARM: dts: qcom: msm8974: add gpu support | From | Konrad Dybcio <> | Date | Sun, 24 Jan 2021 15:56:06 +0100 |
| |
Hi,
> + gpu_opp_table: opp_table { > + status = "disabled";
Is there a good reason to disable this?
> + opp-800000000 { > + opp-hz = /bits/ 64 <800000000>; > + };
No. A330 can't go lightspeed (unless there's some secret ultra-binned msm8974pro-v4-ad-5g). [1]
> + > + opp-500000000 { > + opp-hz = /bits/ 64 <500000000>; > + }; > + > + opp-275000000 { > + opp-hz = /bits/ 64 <275000000>; > + }; > + };
IMHO we should create separate DTs for all revisions of 8974 (sigh) and keep the opp tables in there, only leaving a lowest-common-denominator one here (which according to downstream and the msm/drm driver would be 27000000 /27MHz/) to make it at least probe for everybody..
On a note, max GPU frequencies (based on [1] and grepping for gpu-pwrlevels or qcom,gpu-freq downstream) are:
* 578 MHz for PRO (so -AC)
* 550 MHz is mentioned in [1] but not downstream..
* 450 MHz for everything else (v2.2 has more DVFS steps)
> + // iommus = <&gpu_iommu 0>;
I *think* you're going to need more gpu contexts (user/priv/spare), but don't quote me on that.
Konrad
[1] https://www.anandtech.com/show/7846/the-difference-between-snapdragon-800-and-801-clearing-up-confusion
| |