Messages in this thread | | | Subject | Re: [PATCH v1 0/3] Support building gpio-tegra driver as loadable module | From | Dmitry Osipenko <> | Date | Sun, 24 Jan 2021 02:56:13 +0300 |
| |
24.01.2021 01:50, Linus Walleij пишет: > On Fri, Jan 22, 2021 at 7:59 PM Dmitry Osipenko <digetx@gmail.com> wrote: > >> This small series adds modularization support to the gpio-tegra driver, >> i.e. driver now could be built as a loadable kernel module. >> >> Dmitry Osipenko (3): >> gpio: tegra: Use debugfs_create_devm_seqfile() >> gpio: tegra: Clean up whitespaces in tegra_gpio_driver >> gpio: tegra: Support building driver as a loadable module > > As these three patches clearly make the kernel look better after > than before: > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > However when we are doing this I would strongly encourage you > to also make a patch implementing remove() so you can insmod > rmmod the module at runtime.
The remove() is optional for drivers, it doesn't prevent the rmmod.
| |