lkml.org 
[lkml]   [2021]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 4/7] dt-bindings: regulator: qcom-labibb: Document soft start properties
On Tue, Jan 19, 2021 at 06:44:18PM +0100, AngeloGioacchino Del Regno wrote:
> Document properties to configure soft start and discharge resistor
> for LAB and IBB respectively.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> .../bindings/regulator/qcom-labibb-regulator.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml
> index 53853ec20fe2..7a507692f1ba 100644
> --- a/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml
> @@ -22,6 +22,11 @@ properties:
> type: object
>
> properties:
> + qcom,soft-start-us:
> + $ref: /schemas/types.yaml#/definitions/uint32

Don't need a type when you have standard units.

> + description: Regulator soft start time in microseconds.
> + enum: [200, 400, 600, 800]
> + default: 200
>
> interrupts:
> maxItems: 1
> @@ -35,6 +40,11 @@ properties:
> type: object
>
> properties:
> + qcom,discharge-resistor-kohms:

-kohms is not standard units as documented in property-units.txt (and
.yaml in dtschema). Please use '-ohms'.

Given this is already applied, send an incremental patch.

> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: Discharge resistor value in KiloOhms.
> + enum: [300, 64, 32, 16]
> + default: 300
>
> interrupts:
> maxItems: 1
> --
> 2.30.0
>

\
 
 \ /
  Last update: 2021-01-22 18:16    [W:0.103 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site