Messages in this thread | | | Subject | Re: [PATCH v3] regulator: Make regulator_sync_voltage() usable by coupled regulators | From | Dmitry Osipenko <> | Date | Fri, 22 Jan 2021 19:00:32 +0300 |
| |
22.01.2021 16:40, Mark Brown пишет: > On Fri, Jan 22, 2021 at 01:16:49AM +0300, Dmitry Osipenko wrote: > >> + /* balance only if there are regulators coupled */ >> + if (rdev->coupling_desc.n_coupled > 1) { >> + ret = regulator_balance_voltage(rdev, PM_SUSPEND_ON); >> + goto out; >> + } >> + >> ret = _regulator_do_set_voltage(rdev, min_uV, max_uV); >> >> out: > > This would be clearer written as an if/else rather than using the goto. >
I'll make v4, thanks.
| |