lkml.org 
[lkml]   [2021]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH][next] drm/i915/hdcp: Fix return of value in uninitialized variable ret
    Date
    From: Colin Ian King <colin.king@canonical.com>

    Currently when there are other connectors on the port using HDCP the
    function _intel_hdcp_disable returns a garbage uninitialized value in
    variable ret. I believe the intention is to return 0, so return this
    literal value instead of the value in ret.

    Addresses-Coverity: ("Uninitialized scalar return")
    Fixes: 899c8762f981 ("drm/i915/hdcp: Configure HDCP2.2 MST steram encryption status")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    ---
    drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c
    index db8dff2eeb0a..a0e7b0bf892b 100644
    --- a/drivers/gpu/drm/i915/display/intel_hdcp.c
    +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
    @@ -883,7 +883,7 @@ static int _intel_hdcp_disable(struct intel_connector *connector)
    * until it disabled HDCP encryption for all connectors in MST topology.
    */
    if (dig_port->num_hdcp_streams > 0)
    - return ret;
    + return 0;

    hdcp->hdcp_encrypted = false;
    intel_de_write(dev_priv, HDCP_CONF(dev_priv, cpu_transcoder, port), 0);
    --
    2.29.2
    \
     
     \ /
      Last update: 2021-01-22 16:12    [W:3.446 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site