Messages in this thread | | | Subject | Re: [PATCH v5 3/6] kasan: Add report for async mode | From | Vincenzo Frascino <> | Date | Fri, 22 Jan 2021 13:38:38 +0000 |
| |
On 1/22/21 1:27 PM, Vincenzo Frascino wrote: >> It looks like the original kasan_report() prototype is declared in two >> places (second one in mm/kasan/kasan.h). I'd remove the latter and try >> to have a consistent approach for kasan_report() and >> kasan_report_async(). >> > Ok, I will remove it.
I just realized that the internal interface exposes the kasan_report() interface for the GENERIC KASAN implementation. If I remove it that does not work anymore:
/data1/Projects/LinuxKernel/linux-mte/mm/kasan/common.c: In function ‘__kasan_check_byte’: /data1/Projects/LinuxKernel/linux-mte/mm/kasan/common.c:503:17: error: implicit declaration of function ‘kasan_report’ [-Werror=implicit-function-declaration] 503 | kasan_report((unsigned long)address, 1, false, ip); | ^~~~~~~~~~~~ /data1/Projects/LinuxKernel/linux-mte/mm/kasan/generic.c: In function ‘check_region_inline’: /data1/Projects/LinuxKernel/linux-mte/mm/kasan/generic.c:170:25: error: implicit declaration of function ‘kasan_report’ [-Werror=implicit-function-declaration] 170 | return !kasan_report(addr, size, write, ret_ip); | ^~~~~~~~~~~~ /data1/Projects/LinuxKernel/linux-mte/mm/kasan/report_generic.c: In function ‘__asan_report_load1_noabort’: /data1/Projects/LinuxKernel/linux-mte/mm/kasan/report_generic.c:295:9: error: implicit declaration of function ‘kasan_report’ [-Werror=implicit-function-declaration] 295 | kasan_report(addr, size, false, _RET_IP_); \ | ^~~~~~~~~~~~ /data1/Projects/LinuxKernel/linux-mte/mm/kasan/report_generic.c:306:1: note: in expansion of macro ‘DEFINE_ASAN_REPORT_LOAD’ 306 | DEFINE_ASAN_REPORT_LOAD(1);
To do that cleanly few things need to be shuffled around, Andrey or I can take care of it but if you agree we shall look into this after -rc1.
Thanks!
-- Regards, Vincenzo
| |