lkml.org 
[lkml]   [2021]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 13/15] dt-binding: display: bcm2711-hdmi: Add CEC and hotplug interrupts
Hi Maxime

On Mon, 11 Jan 2021 at 14:23, Maxime Ripard <maxime@cerno.tech> wrote:
>
> The CEC and hotplug interrupts were missing when that binding was
> introduced, let's add them in now that we've figured out how it works.
>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>

Looks reasonable to me, but I'm not a DT bindings expert

Acked-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

> ---
> .../bindings/display/brcm,bcm2711-hdmi.yaml | 20 ++++++++++++++++++-
> 1 file changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml b/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml
> index 7ce06f9f9f8e..6e8ac910bdd8 100644
> --- a/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml
> +++ b/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml
> @@ -53,6 +53,24 @@ properties:
> - const: audio
> - const: cec
>
> + interrupts:
> + items:
> + - description: CEC TX interrupt
> + - description: CEC RX interrupt
> + - description: CEC stuck at low interrupt
> + - description: Wake-up interrupt
> + - description: Hotplug connected interrupt
> + - description: Hotplug removed interrupt
> +
> + interrupt-names:
> + items:
> + - const: cec-tx
> + - const: cec-rx
> + - const: cec-low
> + - const: wakeup
> + - const: hpd-connected
> + - const: hpd-removed
> +
> ddc:
> allOf:
> - $ref: /schemas/types.yaml#/definitions/phandle
> @@ -90,7 +108,7 @@ required:
> - resets
> - ddc
>
> -additionalProperties: false
> +unevaluatedProperties: false
>
> examples:
> - |
> --
> 2.29.2
>

\
 
 \ /
  Last update: 2021-01-22 14:31    [W:0.451 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site