Messages in this thread | | | Date | Fri, 22 Jan 2021 09:51:57 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 1/8] perf arm-spe: Enable sample type PERF_SAMPLE_DATA_SRC |
| |
Em Tue, Jan 19, 2021 at 04:46:51PM +0200, James Clark escreveu: > From: Leo Yan <leo.yan@linaro.org> > > This patch is to enable sample type PERF_SAMPLE_DATA_SRC for Arm SPE in > the perf data, when output the tracing data, it tells tools that it > contains data source in the memory event. > > Signed-off-by: Leo Yan <leo.yan@linaro.org> > Signed-off-by: James Clark <james.clark@arm.com>
I see two Signed-off-by, ok, any Reviewed-by?
- Arnaldo
> Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Ingo Molnar <mingo@redhat.com> > Cc: Arnaldo Carvalho de Melo <acme@kernel.org> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> > Cc: Jiri Olsa <jolsa@redhat.com> > Cc: Namhyung Kim <namhyung@kernel.org> > Cc: John Garry <john.garry@huawei.com> > Cc: Will Deacon <will@kernel.org> > Cc: Mathieu Poirier <mathieu.poirier@linaro.org> > Cc: Al Grant <al.grant@arm.com> > Cc: Andre Przywara <andre.przywara@arm.com> > Cc: Wei Li <liwei391@huawei.com> > Cc: Tan Xiaojun <tanxiaojun@huawei.com> > Cc: Adrian Hunter <adrian.hunter@intel.com> > --- > tools/perf/util/arm-spe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/arm-spe.c b/tools/perf/util/arm-spe.c > index 8901a1656a41..b134516e890b 100644 > --- a/tools/perf/util/arm-spe.c > +++ b/tools/perf/util/arm-spe.c > @@ -803,7 +803,7 @@ arm_spe_synth_events(struct arm_spe *spe, struct perf_session *session) > attr.type = PERF_TYPE_HARDWARE; > attr.sample_type = evsel->core.attr.sample_type & PERF_SAMPLE_MASK; > attr.sample_type |= PERF_SAMPLE_IP | PERF_SAMPLE_TID | > - PERF_SAMPLE_PERIOD; > + PERF_SAMPLE_PERIOD | PERF_SAMPLE_DATA_SRC; > if (spe->timeless_decoding) > attr.sample_type &= ~(u64)PERF_SAMPLE_TIME; > else > -- > 2.28.0 >
--
- Arnaldo
| |