lkml.org 
[lkml]   [2021]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] uacce: Add uacce_ctrl misc device
On Fri, Jan 22, 2021 at 07:33:40PM +0800, Zhou Wang wrote:
> >> +struct uacce_pin_address {
> >> + unsigned long addr;
> >> + unsigned long size;
> >
> > These are not valid ioctl structure members for crossing the user/kernel
> > boundry. Please make them work properly (i.e. use __u64 and friends).
>
> Got it, will modify this to __u64 together with other problems found by 0-day robot.

Please also properly involve the mm and dma developers and, again,
consider just making this a syscall instead of an ioctl.

thanks,

greg k-h

\
 
 \ /
  Last update: 2021-01-22 12:42    [W:0.033 / U:0.860 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site