lkml.org 
[lkml]   [2021]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    Subject[PATCH v2 01/10] mm: use add_page_to_lru_list()
    From
    There is add_page_to_lru_list(), and move_pages_to_lru() should reuse
    it, not duplicate it.

    Link: https://lore.kernel.org/linux-mm/20201207220949.830352-2-yuzhao@google.com/
    Signed-off-by: Yu Zhao <yuzhao@google.com>
    Reviewed-by: Alex Shi <alex.shi@linux.alibaba.com>
    ---
    mm/vmscan.c | 6 +-----
    1 file changed, 1 insertion(+), 5 deletions(-)

    diff --git a/mm/vmscan.c b/mm/vmscan.c
    index 04509994aed4..19875660e8f8 100644
    --- a/mm/vmscan.c
    +++ b/mm/vmscan.c
    @@ -1823,7 +1823,6 @@ static unsigned noinline_for_stack move_pages_to_lru(struct lruvec *lruvec,
    int nr_pages, nr_moved = 0;
    LIST_HEAD(pages_to_free);
    struct page *page;
    - enum lru_list lru;

    while (!list_empty(list)) {
    page = lru_to_page(list);
    @@ -1868,11 +1867,8 @@ static unsigned noinline_for_stack move_pages_to_lru(struct lruvec *lruvec,
    * inhibits memcg migration).
    */
    VM_BUG_ON_PAGE(!lruvec_holds_page_lru_lock(page, lruvec), page);
    - lru = page_lru(page);
    + add_page_to_lru_list(page, lruvec, page_lru(page));
    nr_pages = thp_nr_pages(page);
    -
    - update_lru_size(lruvec, lru, page_zonenum(page), nr_pages);
    - list_add(&page->lru, &lruvec->lists[lru]);
    nr_moved += nr_pages;
    if (PageActive(page))
    workingset_age_nonresident(lruvec, nr_pages);
    --
    2.30.0.280.ga3ce27912f-goog
    \
     
     \ /
      Last update: 2021-01-22 23:10    [W:4.191 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site