Messages in this thread | | | From | Ronak Doshi <> | Subject | Re: [PATCH net-next] vmxnet3: Remove buf_info from device accessible structures | Date | Fri, 22 Jan 2021 08:24:59 +0000 |
| |
On 1/21/21, 5:07 PM, "Jakub Kicinski" <kuba@kernel.org> wrote: > On Tue, 19 Jan 2021 18:19:40 -0800 Ronak Doshi wrote: > > From: Petr Vandrovec <petr@vmware.com> > > > > vmxnet3: Remove buf_info from device accessible structures > > Something happened to the posting, looks like the subject is listed > twice? It got sent twice. Please ignore.
> > - if (!tq->buf_info) > > + tq->buf_info = kmalloc_array_node(tq->tx_ring.size, sizeof(tq->buf_info[0]), > > + GFP_KERNEL | __GFP_ZERO, > > + dev_to_node(&adapter->pdev->dev)); > > kcalloc_node() Sure, will use this callback.
> > + if (!tq->buf_info) { > > + netdev_err(adapter->netdev, "failed to allocate tx buffer info\n") > > Please drop the message, OOM splat will be visible enough. checkpatch > usually points this out
Okay, will drop it. Checkpatch did not complain about the error message though.
Thanks, Ronak
| |