lkml.org 
[lkml]   [2021]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] dt-bindings: pinctrl: qcom: Define common TLMM binding
On 21-01-21, 14:20, Linus Walleij wrote:
> On Wed, Jan 20, 2021 at 11:21 PM Bjorn Andersson
> <bjorn.andersson@linaro.org> wrote:
>
> > Several properties are shared between all TLMM bindings. By providing a
> > common binding to define these properties each platform's binding can be
> > reduced to just listing which of these properties should be checked for
> > - or further specified.
> >
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Reviewed-by: Vinod Koul <vkoul@kernel.org>

> Overall it looks good, just cutting some slack for reviewers (especially
> DT people) before applying.

Yeah it does clean stuff up. I have rebased on SM8350 series on top of this, will post soon.

> > +description:
> > + This defines the common properties used to describe all Qualcomm TLMM
> > + bindings and pinconf/pinmux states for these.
>
> I vaguely recall asking you in the past what the acronym TLMM actually
> means. This would be a good place to expand the acronym so people
> know what these four letters actually represent.

It is Top Level Mode Multiplexer (TLMM) it is actually used in the
binding doc :)

>
> (There, I finally gave you an official reason to go and poke Qualcomm
> hardware engineers about this. ;)
>
> Yours,
> Linus Walleij

--
~Vinod

\
 
 \ /
  Last update: 2021-01-21 18:11    [W:0.129 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site