Messages in this thread | | | Subject | Re: [PATCH v2 1/4] KVM: x86: Factor out x86 instruction emulation with decoding | From | Wei Huang <> | Date | Thu, 21 Jan 2021 09:31:46 -0600 |
| |
On 1/21/21 8:23 AM, Paolo Bonzini wrote: > On 21/01/21 15:04, Maxim Levitsky wrote: >>> +int x86_emulate_decoded_instruction(struct kvm_vcpu *vcpu, int >>> emulation_type, >>> + void *insn, int insn_len) >> Isn't the name of this function wrong? This function decodes the >> instruction. >> So I would expect something like x86_decode_instruction. >> > > Yes, that or x86_decode_emulated_instruction.
I was debating about it while making the change. I will update it to new name in v3.
> > Paolo >
| |