lkml.org 
[lkml]   [2021]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH -v3 3/9] sched: Dont run cpu-online with balance_push() enabled
Date
On 21/01/21 11:17, Peter Zijlstra wrote:
> @@ -7608,6 +7614,12 @@ int sched_cpu_dying(unsigned int cpu)
> }
> rq_unlock_irqrestore(rq, &rf);
>
> + /*
> + * Should really be after we clear cpu_online(), but we're in
> + * stop_machine(), so it all works.
> + */

I believe you noted yourself in some earlier version that this *is* running
with cpu_online(cpu) == false, __cpu_disable() being invoked before the
_DYING .teardown callbacks are run.

> + balance_push_set(cpu, false);
> +
> calc_load_migrate(rq);
> update_max_interval();
> nohz_balance_exit_idle(rq);

\
 
 \ /
  Last update: 2021-01-21 15:03    [W:0.964 / U:2.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site