lkml.org 
[lkml]   [2021]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf evlist: Fix id index for heterogeneous systems
Em Thu, Jan 21, 2021 at 03:39:03PM +0200, Adrian Hunter escreveu:
> On 21/01/21 3:19 pm, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Jan 21, 2021 at 02:54:46PM +0200, Adrian Hunter escreveu:
> >> perf_evlist__set_sid_idx() updates perf_sample_id with the evlist map
> >> index, cpu number and tid. It is passed indexes to the evsel's cpu and
> >> thread maps, but references the evlist's maps instead. That results in
> >> using incorrect cpu numbers on heterogeneous systems. Fix by using evsel
> >> maps.
> >>
> >> The id index (PERF_RECORD_ID_INDEX) is used by AUX area tracing when in
> >> sampling mode. Having an incorrect cpu number causes the trace data to
> >> be attributed to the wrong cpu, and can result in decoder errors because
> >> the trace data is then associated with the wrong process.
> >
> > Can you please provide a Fixes: tag so that the stable@kernel.org guys
> > can apply where appropriate?
>
> Oops sorry missed that. Here it is:
>
> Fixes: 3c659eedada2 ("perf tools: Add id index")


Thanks a lot!

- Arnaldo

\
 
 \ /
  Last update: 2021-01-21 14:48    [W:0.050 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site