lkml.org 
[lkml]   [2021]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] s390/vfio-ap: No need to disable IRQ after queue reset
On Thu, 21 Jan 2021 09:20:44 +0100
Cornelia Huck <cohuck@redhat.com> wrote:

> On Thu, 21 Jan 2021 08:20:08 +0100
> Halil Pasic <pasic@linux.ibm.com> wrote:
[..]
> > --- a/drivers/s390/crypto/vfio_ap_private.h
> > +++ b/drivers/s390/crypto/vfio_ap_private.h
> > @@ -88,11 +88,6 @@ struct ap_matrix_mdev {
> > struct mdev_device *mdev;
> > };
> >
> > -extern int vfio_ap_mdev_register(void);
> > -extern void vfio_ap_mdev_unregister(void);
> > -int vfio_ap_mdev_reset_queue(unsigned int apid, unsigned int apqi,
> > - unsigned int retry);
> > -
> > struct vfio_ap_queue {
> > struct ap_matrix_mdev *matrix_mdev;
> > unsigned long saved_pfn;
> > @@ -100,5 +95,10 @@ struct vfio_ap_queue {
> > #define VFIO_AP_ISC_INVALID 0xff
> > unsigned char saved_isc;
> > };
> > -struct ap_queue_status vfio_ap_irq_disable(struct vfio_ap_queue *q);
> > +
> > +int vfio_ap_mdev_register(void);
> > +void vfio_ap_mdev_unregister(void);
>
> Nit: was moving these two necessary?
>

No not strictly necessary. I decided that having the data types
first and the function prototypes in one place after the former
is nicer.

> > +int vfio_ap_mdev_reset_queue(struct vfio_ap_queue *q,
> > + unsigned int retry);
> > +
> > #endif /* _VFIO_AP_PRIVATE_H_ */
> >
> > base-commit: 9791581c049c10929e97098374dd1716a81fefcc
>
> Anyway, if I didn't entangle myself in the various branches, this seems
> sane.
>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
>

Thank you very much!

Regards,
Halil

\
 
 \ /
  Last update: 2021-01-21 13:57    [W:0.040 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site