lkml.org 
[lkml]   [2021]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 5/5] ASoC: Intel: bytcr_wm5102: Add machine driver for BYT/WM5102
    On Wed, Jan 20, 2021 at 10:49:57PM +0100, Hans de Goede wrote:
    > From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    >
    > Add a new ASoc Machine driver for Intel Baytrail platforms with a
    > Wolfson Microelectronics WM5102 codec.
    >
    > This is based on a past contributions [1] from Paulo Sergio Travaglia
    > <pstglia@gmail.com> based on the Levono kernel [2] combined with
    > insights in things like the speaker GPIO from the android-x86 android
    > port for the Lenovo Yoga Tablet 2 1051F/L [3].
    >
    > [1] https://patchwork.kernel.org/project/alsa-devel/patch/593313f5.3636c80a.50e05.47e9@mx.google.com/
    > [2] https://github.com/lenovo-yt2-dev/android_kernel_lenovo_baytrail/blob/cm-12.1/sound/soc/intel/board/byt_bl_wm5102.c
    > [3] https://github.com/Kitsune2222/Android_Yoga_Tablet_2-1051F_Kernel
    >
    > The original machine driver from the Android ports was a crude modified
    > copy of bytcr_rt5640.c adjusted to work with the WM5102 codec.
    > This version has been extensively reworked to:
    >
    > 1. Remove all rt5640 related quirk handling. to the best of my knowledge
    > this setup is only used on the Lenovo Yoga Tablet 2 series (8, 10 and 13
    > inch models) which all use the same setup. So there is no need to deal
    > with all the variations with which we need to deal on rt5640 boards.
    >
    > 2. Rework clock handling, properly turn off the FLL and the platform-clock
    > when they are no longer necessary and don't reconfigure the FLL
    > unnecessarily when it is already running. This fixes a number of:
    > "Timed out waiting for lock" warnings being logged.
    >
    > 3. Add the GPIO controlled Speaker-VDD regulator as a DAPM_SUPPLY
    >
    > This only adds the machine driver and ACPI hooks, the BYT-CR detection
    > quirk which these devices need will be added in a separate patch.
    >
    > BugLink: https://github.com/thesofproject/linux/issues/2485
    > Co-authored-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
    > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
    > ---

    Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>

    Thanks,
    Charles

    \
     
     \ /
      Last update: 2021-01-21 11:45    [W:4.602 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site