Messages in this thread | | | Date | Wed, 20 Jan 2021 23:47:32 -0600 | From | Bjorn Andersson <> | Subject | Re: [PATCH 2/2] clk: qcom: gcc: Add global clock controller driver for SC8180x |
| |
On Wed 20 Jan 16:35 CST 2021, Bjorn Andersson wrote: > diff --git a/drivers/clk/qcom/gcc-sc8180x.c b/drivers/clk/qcom/gcc-sc8180x.c [..] > +static struct gdsc emac_gdsc = { > + .gdscr = 0x106004,
Seems like I missed squashing the fixup where I subtract the gcc base address after migrating these from the downstream dts.
As written the platform doesn't boot.
Please let me know if there's any other feedback before I respin v2.
Regards, Bjorn
> + .pd = { > + .name = "emac_gdsc", > + }, > + .pwrsts = PWRSTS_OFF_ON, > + .flags = POLL_CFG_GDSCR, > +};
| |