lkml.org 
[lkml]   [2021]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] scripts/spelling.txt: increase error-prone spell checking
From
Date
Hi,

On 21/01/21 04:21, Chunyou Tang wrote:
> On Wed, 20 Jan 2021 19:09:05 -0800
> Joe Perches <joe@perches.com> wrote:
>
>> On Wed, 2021-01-20 at 19:02 -0800, Randy Dunlap wrote:
>>> On 1/20/21 6:07 PM, ChunyouTang wrote:
>>>> From: tangchunyou <tangchunyou@yulong.com>
>>>>
>>>> Increase direcly,maping,manger spelling error check
>>>
>>> Hi,
>>> I don't see all of those in the patch below.
>>> What happened?
>>
>> I think mostly it's just a poor commit message as
>> direcly and manger are already in spelling.txt
>>
>>>> diff --git a/scripts/spelling.txt b/scripts/spelling.txt
>> []
>>>> @@ -875,6 +875,7 @@ manger||manager
>>>>  manoeuvering||maneuvering
>>>>  manufaucturing||manufacturing
>>>>  mappping||mapping
>>>> +maping||mapping
>>>>  matchs||matches
>>>>  mathimatical||mathematical
>>>>  mathimatic||mathematic
>>
>
> yes,you are right,the commit message is bad,I change the commit message
>
> and resend it.

While doing that, also improve the subject (1st line of commit message)
by mentioning the typo you are adding. For example, as in previous commits:

scripts/spelling.txt: add "maping" typo

It's more informative and even shorter.

Thanks
--
Luca

\
 
 \ /
  Last update: 2021-01-21 09:45    [W:0.057 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site