lkml.org 
[lkml]   [2021]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] rtsx: pci: fix device aspm state bug
Date
> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Thursday, January 21, 2021 3:46 PM
> To: 吳昊澄 Ricky <ricky_wu@realtek.com>
> Cc: arnd@arndb.de; ricky_wu@realtek.corp-partner.google.com;
> sashal@kernel.org; levinale@google.com; keitasuzuki.park@sslab.ics.keio.ac.jp;
> kdlnx@doth.eu; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] rtsx: pci: fix device aspm state bug
>
> On Thu, Jan 21, 2021 at 03:28:58PM +0800, ricky_wu@realtek.com wrote:
> > From: Ricky Wu <ricky_wu@realtek.corp-partner.google.com>
> >
> > changed rtsx_pci_disable_aspm() to rtsx_disable_aspm() make sure
> > pcr->aspm_enabled to sync with aspm state
>
> Can you make this a bit more descriptive?
>
Changed rtsx_pci_disable_aspm() to rtsx_disable_aspm() make sure
pcr->aspm_enabled to sync with aspm state.
rtsx_pci_disable_aspm() this function disable aspm by setting config space directly
did not change value of pcr->aspm_enabled so changed to use rtsx_disable_aspm().
Give initial value to pcr->aspm_enabled by reading config space setting at init_hw().

>
> >
> > BUG=b:175338107
> > TEST=chromeos-kernel-5_4
>
> What are these lines for?
>
> >
> > Signed-off-by: Ricky Wu <ricky_wu@realtek.corp-partner.google.com>
>
> This email does not match your From: address :(
>
> > Change-Id: I4b146dcdaaf2f2a965381c32780b0b110d751258
>
> Please use checkpatch.pl before sending patches to us :(
>
> And why did you send this twice?
>
> thanks,
>
> greg k-h
>
> ------Please consider the environment before printing this e-mail.
\
 
 \ /
  Last update: 2021-01-21 09:18    [W:0.048 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site