Messages in this thread | | | Date | Wed, 20 Jan 2021 21:35:22 -0800 | From | Jakub Kicinski <> | Subject | Re: [PATCH net-next 3/5] net: ipa: have gsi_channel_update() return a value |
| |
On Wed, 20 Jan 2021 16:03:59 -0600 Alex Elder wrote: > Have gsi_channel_update() return the first transaction in the > updated completed transaction list, or NULL if no new transactions > have been added. > > Signed-off-by: Alex Elder <elder@linaro.org>
> @@ -1452,7 +1452,7 @@ void gsi_channel_doorbell(struct gsi_channel *channel) > } > > /* Consult hardware, move any newly completed transactions to completed list */ > -static void gsi_channel_update(struct gsi_channel *channel) > +struct gsi_trans *gsi_channel_update(struct gsi_channel *channel)
Why did it lose the 'static'?
drivers/net/ipa/gsi.c:1455:19: warning: no previous prototype for ‘gsi_channel_update’ [-Wmissing-prototypes] 1455 | struct gsi_trans *gsi_channel_update(struct gsi_channel *channel) | ^~~~~~~~~~~~~~~~~~
| |