Messages in this thread Patch in this message | | | From | Willy Tarreau <> | Subject | [PATCH 7/9] tools/nolibc: remove incorrect definitions of __ARCH_WANT_* | Date | Thu, 21 Jan 2021 08:20:29 +0100 |
| |
These definitions were added with support for aarch64 when some syscall definitions were missing (__NR_dup2, __NR_fork, __NR_getpgrp, etc), but these were actually wrong because these syscalls do not exist on this platform, and definiting these resulted in exposing invalid definitions.
The missing syscalls were since implemented based on the newer ones (__NR_dup3, __NR_clone, __NR_getpgid) so these incorrect defintions are definitely not needed anymore.
Thanks to Mark Rutland for spotting this incorrect analysis and explaining why it was wrong.
[This is nolibc's upstream commit 00b1b0d9b2a4]
Reported-by: Mark Rutland <mark.rutland@arm.com> Link: https://lore.kernel.org/lkml/20210119153147.GA5083@paulmck-ThinkPad-P72 Cc: "Paul E. McKenney" <paulmck@kernel.org> Cc: valentin.schneider@arm.com Signed-off-by: Willy Tarreau <w@1wt.eu> --- tools/include/nolibc/nolibc.h | 8 -------- 1 file changed, 8 deletions(-)
diff --git a/tools/include/nolibc/nolibc.h b/tools/include/nolibc/nolibc.h index 611d9d15899d..475d956ed1d6 100644 --- a/tools/include/nolibc/nolibc.h +++ b/tools/include/nolibc/nolibc.h @@ -81,14 +81,6 @@ * */ -/* Some archs (at least aarch64) don't expose the regular syscalls anymore by - * default, either because they have an "_at" replacement, or because there are - * more modern alternatives. For now we'd rather still use them. - */ -#define __ARCH_WANT_SYSCALL_NO_AT -#define __ARCH_WANT_SYSCALL_NO_FLAGS -#define __ARCH_WANT_SYSCALL_DEPRECATED - #include <asm/unistd.h> #include <asm/ioctls.h> #include <asm/errno.h> -- 2.28.0
| |