Messages in this thread | | | Subject | Re: [PATCH v5 1/2] lib: stackdepot: Add support to configure STACK_HASH_SIZE | From | Vijayanand Jitta <> | Date | Fri, 22 Jan 2021 09:30:00 +0530 |
| |
On 1/22/2021 5:49 AM, Minchan Kim wrote: > On Mon, Jan 18, 2021 at 03:26:41PM +0530, vjitta@codeaurora.org wrote: >> From: Yogesh Lal <ylal@codeaurora.org> >> >> Use CONFIG_STACK_HASH_ORDER to configure STACK_HASH_SIZE. >> >> Aim is to have configurable value for STACK_HASH_SIZE, >> so depend on use case one can configure it. >> >> One example is of Page Owner, default value of >> STACK_HASH_SIZE lead stack depot to consume 8MB of static memory. >> Making it configurable and use lower value helps to enable features like >> CONFIG_PAGE_OWNER without any significant overhead. > > The description could be improved to prevent confusing. > CONFIG_PAGE_OWNER works only if page_owner=on via kernel parameter > on CONFIG_PAGE_OWNER configured system. > Thus, unless admin enable it via command line option, the stackdepot > will just waste 8M memory without any customer. >
Sure, will update the commit text as suggested.
Thanks, Vijay >> >> Signed-off-by: Yogesh Lal <ylal@codeaurora.org> >> Signed-off-by: Vinayak Menon <vinmenon@codeaurora.org> >> Signed-off-by: Vijayanand Jitta <vjitta@codeaurora.org> > Reviewed-by: Minchan Kim <minchan@kernel.org> >
-- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
| |