lkml.org 
[lkml]   [2021]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 03/20] objtool: Fix ".cold" section suffix check for newer versions of GCC
    Date
    With my version of GCC 9.3.1 the ".cold" subfunctions no longer have a
    numbered suffix, so the trailing period is no longer there.

    Presumably this doesn't yet trigger a user-visible bug since most of the
    subfunction detection logic is duplicated. I only found it when
    testing vmlinux.o validation.

    Fixes: 54262aa28301 ("objtool: Fix sibling call detection")
    Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
    ---
    tools/objtool/check.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/tools/objtool/check.c b/tools/objtool/check.c
    index 081572170f6b..c964cd56b557 100644
    --- a/tools/objtool/check.c
    +++ b/tools/objtool/check.c
    @@ -846,8 +846,8 @@ static int add_jump_destinations(struct objtool_file *file)
    * case where the parent function's only reference to a
    * subfunction is through a jump table.
    */
    - if (!strstr(insn->func->name, ".cold.") &&
    - strstr(insn->jump_dest->func->name, ".cold.")) {
    + if (!strstr(insn->func->name, ".cold") &&
    + strstr(insn->jump_dest->func->name, ".cold")) {
    insn->func->cfunc = insn->jump_dest->func;
    insn->jump_dest->func->pfunc = insn->func;

    --
    2.29.2
    \
     
     \ /
      Last update: 2021-01-21 22:35    [W:7.278 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site