lkml.org 
[lkml]   [2021]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] perf metricgroup: Fix system PMU metrics
From
Date
On 20/01/2021 12:56, Jiri Olsa wrote:
> that's fixing the issue for me, this was crashing:
> # perf stat -a -I 1000 -M L1D_Cache_Fill_BW,L2_Cache_Fill_BW
>
> could you please send it formaly, so it can be merged?
>

I will do it today. But I want to make sure that the logic is correct,
so checking it all again, i.e. I can fix the segfault but the logic may
be wrong.

I think Ian wrote this code originally or made the most recent rework
(which I tried to fix), so would like him to check also.

> I can't reproduce the original patch issue and I need
> to check the code in more depth

It should only occur for metrics when using system PMUs, i.e. match via
identifier file, so I really doubt your system has them.

I'd like to add a test for this - I need to think how...

Cheers,
John

\
 
 \ /
  Last update: 2021-01-20 15:42    [W:0.116 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site