Messages in this thread | | | Subject | Re: [PATCH] perf metricgroup: Fix system PMU metrics | From | John Garry <> | Date | Wed, 20 Jan 2021 13:07:57 +0000 |
| |
On 20/01/2021 12:56, Jiri Olsa wrote: > that's fixing the issue for me, this was crashing: > # perf stat -a -I 1000 -M L1D_Cache_Fill_BW,L2_Cache_Fill_BW > > could you please send it formaly, so it can be merged? >
I will do it today. But I want to make sure that the logic is correct, so checking it all again, i.e. I can fix the segfault but the logic may be wrong.
I think Ian wrote this code originally or made the most recent rework (which I tried to fix), so would like him to check also.
> I can't reproduce the original patch issue and I need > to check the code in more depth
It should only occur for metrics when using system PMUs, i.e. match via identifier file, so I really doubt your system has them.
I'd like to add a test for this - I need to think how...
Cheers, John
| |