lkml.org 
[lkml]   [2021]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] i2c: sprd:: depend on COMMON_CLK to fix compile tests
    Hi,

    On Sun, Jan 17, 2021 at 7:43 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
    >
    > The I2C_SPRD uses Common Clock Framework thus it cannot be built on
    > platforms without it (e.g. compile test on MIPS with LANTIQ):
    >
    > /usr/bin/mips-linux-gnu-ld: drivers/i2c/busses/i2c-sprd.o: in function `sprd_i2c_probe':
    > i2c-sprd.c:(.text.sprd_i2c_probe+0x254): undefined reference to `clk_set_parent'
    >
    > Fixes: 4a2d5f663dab ("i2c: Enable compile testing for more drivers")
    > Reported-by: kernel test robot <lkp@intel.com>
    > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

    LGTM. Thanks.
    Reviewed-by: Baolin Wang <baolin.wang7@gmail.com>

    > ---
    > drivers/i2c/busses/Kconfig | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
    > index d4d60ad0eda0..ab1f39ac39f4 100644
    > --- a/drivers/i2c/busses/Kconfig
    > +++ b/drivers/i2c/busses/Kconfig
    > @@ -1013,6 +1013,7 @@ config I2C_SIRF
    > config I2C_SPRD
    > tristate "Spreadtrum I2C interface"
    > depends on I2C=y && (ARCH_SPRD || COMPILE_TEST)
    > + depends on COMMON_CLK
    > help
    > If you say yes to this option, support will be included for the
    > Spreadtrum I2C interface.
    > --
    > 2.25.1
    >


    --
    Baolin Wang

    \
     
     \ /
      Last update: 2021-01-20 07:32    [W:2.201 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site