Messages in this thread | | | Date | Wed, 20 Jan 2021 16:59:48 -0600 | From | Josh Poimboeuf <> | Subject | Re: [PATCH] checkpatch: add warning for avoiding .L prefix symbols in assembly files |
| |
On Wed, Jan 20, 2021 at 10:57:03AM -0800, Nick Desaulniers wrote: > > $ git grep -P '^\s*SYM_[A-Z]+_(?:START|END)(?:_[A-Z_]+)?\s*\(\s*\.L' -- '*.S' > > arch/x86/boot/compressed/head_32.S:SYM_FUNC_START_LOCAL_NOALIGN(.Lrelocated) > > arch/x86/boot/compressed/head_32.S:SYM_FUNC_END(.Lrelocated) > > arch/x86/boot/compressed/head_64.S:SYM_FUNC_START_LOCAL_NOALIGN(.Lrelocated) > > arch/x86/boot/compressed/head_64.S:SYM_FUNC_END(.Lrelocated) > > arch/x86/boot/compressed/head_64.S:SYM_FUNC_START_LOCAL_NOALIGN(.Lpaging_enabled) > > arch/x86/boot/compressed/head_64.S:SYM_FUNC_END(.Lpaging_enabled) > > arch/x86/boot/compressed/head_64.S:SYM_FUNC_START_LOCAL_NOALIGN(.Lno_longmode) > > arch/x86/boot/compressed/head_64.S:SYM_FUNC_END(.Lno_longmode) > > arch/x86/boot/pmjump.S:SYM_FUNC_START_LOCAL_NOALIGN(.Lin_pm32) > > arch/x86/boot/pmjump.S:SYM_FUNC_END(.Lin_pm32) > > arch/x86/entry/entry_64.S:SYM_CODE_START_LOCAL_NOALIGN(.Lbad_gs) > > arch/x86/entry/entry_64.S:SYM_CODE_END(.Lbad_gs) > > arch/x86/lib/copy_user_64.S:SYM_CODE_START_LOCAL(.Lcopy_user_handle_tail) > > arch/x86/lib/copy_user_64.S:SYM_CODE_END(.Lcopy_user_handle_tail) > > arch/x86/lib/getuser.S:SYM_CODE_START_LOCAL(.Lbad_get_user_clac) > > arch/x86/lib/getuser.S:SYM_CODE_END(.Lbad_get_user_clac) > > arch/x86/lib/getuser.S:SYM_CODE_START_LOCAL(.Lbad_get_user_8_clac) > > arch/x86/lib/getuser.S:SYM_CODE_END(.Lbad_get_user_8_clac) > > arch/x86/lib/putuser.S:SYM_CODE_START_LOCAL(.Lbad_put_user_clac) > > arch/x86/lib/putuser.S:SYM_CODE_END(.Lbad_put_user_clac) > > arch/x86/realmode/rm/wakeup_asm.S:SYM_DATA_START_LOCAL(.Lwakeup_idt) > > arch/x86/realmode/rm/wakeup_asm.S:SYM_DATA_END(.Lwakeup_idt) > > Josh, I assume objtool does not annotate code under: > arch/x86/boot/ > arch/x86/entry/ > arch/x86/realmode/ > ? > > The rest, ie > arch/x86/lib/ > seem potentially relevant?
Both arch/x86/entry/* and arch/x86/lib/* are read by objtool and should probably be fixed up.
-- Josh
| |