lkml.org 
[lkml]   [2021]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3 02/21] x86/fpu/xstate: Modify state copy helpers to handle both static and dynamic buffers
Date
On Jan 15, 2021, at 04:50, Borislav Petkov <bp@suse.de> wrote:
> On Wed, Dec 23, 2020 at 07:56:58AM -0800, Chang S. Bae wrote:
>>
>> -void copy_xstate_to_kernel(struct membuf to, struct xregs_state *xsave);
>> -int copy_kernel_to_xstate(struct xregs_state *xsave, const void *kbuf);
>> -int copy_user_to_xstate(struct xregs_state *xsave, const void __user *ubuf);
>> -void copy_supervisor_to_kernel(struct xregs_state *xsave);
>> +void copy_xstate_to_kernel(struct membuf to, struct fpu *fpu);
>> +int copy_kernel_to_xstate(struct fpu *fpu, const void *kbuf);
>> +int copy_user_to_xstate(struct fpu *fpu, const void __user *ubuf);
>> +void copy_supervisor_to_kernel(struct fpu *fpu);
>
> Hmm, so those functions have "xstate" in the name because they took and
> @xstate parameter. I guess not such a big deal you changing them, just
> pointing out what the naming logic was.

I will add a sentence like this if looks fine:

"The copy functions used to have ‘xstate' in the name as they took a struct
xregs_state * pointer."

Thanks,
Chang
\
 
 \ /
  Last update: 2021-01-19 21:23    [W:0.137 / U:0.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site