Messages in this thread | | | Subject | Re: [PATCH v2] x86/vm86/32: Remove VM86_SCREEN_BITMAP support | From | stsp <> | Date | Tue, 19 Jan 2021 22:13:01 +0300 |
| |
19.01.2021 20:40, Andy Lutomirski пишет: > The implementation was rather buggy. It unconditionally marked PTEs > read-only, even for VM_SHARED mappings. I'm not sure whether this is > actually a problem, but it certainly seems unwise. More importantly, it > released the mmap lock before flushing the TLB, which could allow a racing > CoW operation to falsely believe that the underlying memory was not > writable. > > I can't find any users at all of this mechanism, so just remove it. > > Cc: Andrea Arcangeli <aarcange@redhat.com> > Cc: Linux-MM <linux-mm@kvack.org> > Cc: Jason Gunthorpe <jgg@ziepe.ca> > Cc: x86@kernel.org > Cc: Linus Torvalds <torvalds@linux-foundation.org> > Cc: Matthew Wilcox <willy@infradead.org> > Cc: Jann Horn <jannh@google.com> > Cc: Jan Kara <jack@suse.cz> > Cc: Yu Zhao <yuzhao@google.com> > Cc: Peter Xu <peterx@redhat.com> > Cc: Stas Sergeev <stsp@list.ru> > Cc: Brian Gerst <brgerst@gmail.com> > Signed-off-by: Andy Lutomirski <luto@kernel.org> > --- Acked-by: stsp2@yandex.ru
dosemu2 just uses mprotect(). The BIOSSEG stuff in vm86_32.c is also unused btw.
| |