lkml.org 
[lkml]   [2021]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] gpio: sifive: select IRQ_DOMAIN_HIERARCHY rather than depend on it
On Tue, Jan 19, 2021 at 4:18 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> This is the only driver in the kernel source tree that depends on
> IRQ_DOMAIN_HIERARCHY instead of selecting it. Since it is not a
> visible Kconfig symbol, depending on it (expecting a user to
> set/enable it) doesn't make much sense, so change it to select
> instead of "depends on".
>
> Fixes: 96868dce644d ("gpio/sifive: Add GPIO driver for SiFive SoCs")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Cc: linux-gpio@vger.kernel.org
> Cc: Thierry Reding <treding@nvidia.com>
> Cc: Greentime Hu <greentime.hu@sifive.com>
> Cc: Yash Shah <yash.shah@sifive.com>
> ---
> drivers/gpio/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- linux-next-20210118.orig/drivers/gpio/Kconfig
> +++ linux-next-20210118/drivers/gpio/Kconfig
> @@ -521,7 +521,8 @@ config GPIO_SAMA5D2_PIOBU
>
> config GPIO_SIFIVE
> bool "SiFive GPIO support"
> - depends on OF_GPIO && IRQ_DOMAIN_HIERARCHY
> + depends on OF_GPIO
> + select IRQ_DOMAIN_HIERARCHY
> select GPIO_GENERIC
> select GPIOLIB_IRQCHIP
> select REGMAP_MMIO

Applied, thanks!

Bart

\
 
 \ /
  Last update: 2021-01-19 14:41    [W:0.341 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site