Messages in this thread | | | From | Marc Kleine-Budde <> | Subject | Re: [PATCH] can: mcp251xfd: mcp251xfd_handle_ivmif(): fix wrong NULL pointer check | Date | Tue, 19 Jan 2021 08:54:32 +0100 |
| |
On 1/19/21 3:02 AM, angkery wrote: > From: Junlin Yang <yangjunlin@yulong.com> > > if alloc_can_err_skb() returns NULL, we should check skb instead of cf.
Have a look at the function, there is a check for cf several times before this. But as cf is initialized as NULL this is should be no problem.
While in:
| ca4c6ebeeb50 can: mcp251xfd: mcp251xfd_handle_rxif_one(): | fix wrong NULL pointer check
a real problem has been fixed.
Marc
-- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[unhandled content-type:application/pgp-signature] | |