Messages in this thread | | | Subject | Re: [PATCH] opp: Prepare for ->set_opp() helper to work without regulators | From | Dmitry Osipenko <> | Date | Tue, 19 Jan 2021 20:18:00 +0300 |
| |
19.01.2021 09:35, Viresh Kumar пишет: > Until now the ->set_opp() helper (i.e. special implementation for > setting the OPPs for platforms) was implemented only to take care of > multiple regulators case, but going forward we would need that for other > use cases as well. > > This patch prepares for that by allocating the regulator specific part > from dev_pm_opp_set_regulators() and the opp helper part from > dev_pm_opp_register_set_opp_helper(). > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- > Dmitry, > > I haven't tested this patch, can you please help with that ? > > drivers/opp/core.c | 81 ++++++++++++++++++++++++---------------------- > drivers/opp/opp.h | 2 ++ > 2 files changed, 45 insertions(+), 38 deletions(-)
Works good, thank you. It also almost looks good to me, please see my other reply regarding the locks.
Tested-by: Dmitry Osipenko <digetx@gmail.com>
Now the set_opp() needs to be taught about the sod_supplies in order to actually make it to work without the regulators, I'll make a patch on top of this change.
| |