Messages in this thread | | | Subject | Re: [PATCH] sh_eth: Fix power down vs. is_opened flag ordering | From | Sergei Shtylyov <> | Date | Mon, 18 Jan 2021 19:56:58 +0300 |
| |
On 1/18/21 6:08 PM, Geert Uytterhoeven wrote:
> sh_eth_close() does a synchronous power down of the device before > marking it closed. Revert the order, to make sure the device is never > marked opened while suspended. > > While at it, use pm_runtime_put() instead of pm_runtime_put_sync(), as > there is no reason to do a synchronous power down. > > Fixes: 7fa2955ff70ce453 ("sh_eth: Fix sleeping function called from invalid context") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Sergei Shtylyov <sergei.shtylyov@gmail.com>
[...]
MBR, Sergei
| |