Messages in this thread | | | Date | Mon, 18 Jan 2021 15:41:23 +0100 | From | Jan Kara <> | Subject | Re: [PATCH] isofs: release buffer head before return |
| |
On Mon 18-01-21 04:04:55, Pan Bian wrote: > Release the buffer header before returning error code. > > Fixes: 2deb1acc653c ("isofs: fix access to unallocated memory when reading corrupted filesystem") > Signed-off-by: Pan Bian <bianpan2016@163.com>
OK, good spotting. But the other hunk in commit 2deb1acc653c seems to have the same problem so we might fix it as well when we are at it?
Honza
> --- > fs/isofs/dir.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/isofs/dir.c b/fs/isofs/dir.c > index f0fe641893a5..b9e6a7ec78be 100644 > --- a/fs/isofs/dir.c > +++ b/fs/isofs/dir.c > @@ -152,6 +152,7 @@ static int do_isofs_readdir(struct inode *inode, struct file *file, > printk(KERN_NOTICE "iso9660: Corrupted directory entry" > " in block %lu of inode %lu\n", block, > inode->i_ino); > + brelse(bh); > return -EIO; > } > > -- > 2.17.1 > -- Jan Kara <jack@suse.com> SUSE Labs, CR
| |