lkml.org 
[lkml]   [2021]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 074/152] habanalabs: Fix memleak in hl_device_reset
    Date
    From: Dinghao Liu <dinghao.liu@zju.edu.cn>

    [ Upstream commit b000700d6db50c933ce8b661154e26cf4ad06dba ]

    When kzalloc() fails, we should execute hl_mmu_fini()
    to release the MMU module. It's the same when
    hl_ctx_init() fails.

    Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
    Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
    Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/misc/habanalabs/common/device.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/misc/habanalabs/common/device.c b/drivers/misc/habanalabs/common/device.c
    index 783bbdcb1e618..09c328ee65da8 100644
    --- a/drivers/misc/habanalabs/common/device.c
    +++ b/drivers/misc/habanalabs/common/device.c
    @@ -1027,6 +1027,7 @@ again:
    GFP_KERNEL);
    if (!hdev->kernel_ctx) {
    rc = -ENOMEM;
    + hl_mmu_fini(hdev);
    goto out_err;
    }

    @@ -1038,6 +1039,7 @@ again:
    "failed to init kernel ctx in hard reset\n");
    kfree(hdev->kernel_ctx);
    hdev->kernel_ctx = NULL;
    + hl_mmu_fini(hdev);
    goto out_err;
    }
    }
    --
    2.27.0


    \
     
     \ /
      Last update: 2021-01-18 15:23    [W:4.127 / U:0.356 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site