lkml.org 
[lkml]   [2021]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 1/7] acpi: utils: move acpi_lpss_dep() to utils
    On Mon, Jan 18, 2021 at 09:24:10AM +0200, Laurent Pinchart wrote:
    > On Mon, Jan 18, 2021 at 12:34:22AM +0000, Daniel Scally wrote:

    ...

    > > +bool acpi_lpss_dep(struct acpi_device *adev, acpi_handle handle);
    >
    > "lpss" stands for low power subsystem, an Intel device within the PCH
    > that handles I2C, SPI, UART, ... I think the function should be renamed,
    > as it's now generic. acpi_dev_has_dep() is a potential candidate, I'm
    > sure better ones exist. A bit of kerneldoc would also not hurt.

    Actually a good suggestions. Please apply my tag after addressing above.

    --
    With Best Regards,
    Andy Shevchenko


    \
     
     \ /
      Last update: 2021-01-18 13:57    [W:2.700 / U:1.208 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site