Messages in this thread | | | Date | Mon, 18 Jan 2021 14:29:50 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2 1/7] acpi: utils: move acpi_lpss_dep() to utils |
| |
On Mon, Jan 18, 2021 at 09:24:10AM +0200, Laurent Pinchart wrote: > On Mon, Jan 18, 2021 at 12:34:22AM +0000, Daniel Scally wrote:
...
> > +bool acpi_lpss_dep(struct acpi_device *adev, acpi_handle handle); > > "lpss" stands for low power subsystem, an Intel device within the PCH > that handles I2C, SPI, UART, ... I think the function should be renamed, > as it's now generic. acpi_dev_has_dep() is a potential candidate, I'm > sure better ones exist. A bit of kerneldoc would also not hurt.
Actually a good suggestions. Please apply my tag after addressing above.
-- With Best Regards, Andy Shevchenko
| |